fix(suspense): clear placeholder and fallback el refs after resolved to enable GC#13928
Merged
edison1105 merged 5 commits intomainfrom Nov 5, 2025
Merged
fix(suspense): clear placeholder and fallback el refs after resolved to enable GC#13928edison1105 merged 5 commits intomainfrom
edison1105 merged 5 commits intomainfrom
Conversation
WalkthroughClear GC-sensitive vnode references in Suspense: remove fallback vnode Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Async as Async dep / component
participant Suspense as Suspense boundary
participant Fallback as Fallback VNode (ssFallback)
participant Placeholder as Placeholder VNode
participant DOM as DOM
Note over Suspense,Async: Async dependency resolves / transitions complete
Async->>Suspense: resolve()
Suspense->>Suspense: determine isInFallback
alt delayed enter finished & in fallback
Suspense->>Fallback: clear `el` reference (fallback.el = null)
Suspense->>DOM: remove fallback/active nodes
else unmount active branch & in fallback
Suspense->>Fallback: clear `el` reference (fallback.el = null)
Suspense->>DOM: remove active branch nodes
end
Note over Suspense,Placeholder: removing placeholder during resolve
Suspense->>Placeholder: set `placeholder = null`
Suspense->>DOM: remove placeholder node
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
bd5f7a5 to
588de48
Compare
…/github.com/vuejs/core into pr/edison1105/13928
Member
Author
|
/ecosystem-ci run |
Contributor
|
📝 Ran ecosystem CI: Open
|
This was referenced Dec 6, 2025
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #13732 (comment)
related PR #13560
Summary by CodeRabbit